On Wed, Nov 16, 2022 at 2:30 PM Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > On 15/11/2022 23:34, Conor Dooley wrote: > > On Mon, Nov 14, 2022 at 05:59:00PM +0530, Anup Patel wrote: > >> On Sun, Nov 13, 2022 at 8:18 PM Conor Dooley <conor@xxxxxxxxxx> wrote: > > > >>> Also, the file name says "riscv,imsic", the description says "IMSIC" but > >>> you've used "imsics" in the compatible. Is this a typo, or a plural? > >> > >> Yes, the file name should be consistent. I will update the file name. > > > > Is there a reason why the compatible is plural when all of the other > > mentions etc do not have an "s"? It really did look like a typo to me. > > > > It's the "incoming MSI controller", so I am unsure as to where the "s" > > actually even comes from. Why not just use "riscv,imsic"? > > Yep, should be rather consistent with all others, and IMSIC stands for > Integrated Circuit? This is intentionally plural because even though we have one IMSIC per-CPU, Linux (and various OSes) expect one DT node as MSI controller targeting all CPUs. The plural compatible string "riscv,imsics" was chosen based on consensus on RISC-V AIA Task Group meetings. Regards, Anup
