On Wed, Nov 16, 2022 at 09:16:32AM +0100, Johan Hovold wrote: > On Wed, Nov 16, 2022 at 01:22:07PM +0530, Parikshit Pareek wrote: > > Introduce the Qualcomm SA8540P ride automotive platform, also known as > > Qdrive-3 development board. > > > > This initial contribution supports SMP, CPUFreq, cluster idle, UFS, RPMh > > regulators, debug UART, PMICs, remoteprocs and USB. > > > > The SA8540P ride contains four PM8450 PMICs. A separate DTSI file has > > been created for PMIC, so that it can be used for future SA8540P based > > boards. > > > > Signed-off-by: Parikshit Pareek <quic_ppareek@xxxxxxxxxxx> > > > +&ufs_mem_hc { > > + reset-gpios = <&tlmm 228 GPIO_ACTIVE_LOW>; > > + > > + vcc-supply = <&vreg_l17c>; > > + vcc-max-microamp = <800000>; > > + vccq-supply = <&vreg_l6c>; > > + vccq-max-microamp = <900000>; > > + > > + status = "disabled"; > > +}; > > + > > +&ufs_mem_phy { > > + vdda-phy-supply = <&vreg_l8g>; > > + vdda-pll-supply = <&vreg_l3g>; > > + > > + status = "disabled"; > > +}; > > Why are these disabled? This should be mentioned somewhere (e.g. commit > message and/or comment) or you can drop the nodes until support is in > place. My bad. Happened by mistake. > > Johan Regards, Parikshit Pareek