RE: [PATCH 2/3] dt-bindings: pwm: rzg2l-gpt: Document renesas,poegs property

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Krzysztof Kozlowski,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Sent: 04 November 2022 17:11
> To: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>; Thierry Reding
> <thierry.reding@xxxxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>; Krzysztof
> Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>
> Cc: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>; linux-
> pwm@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; Geert Uytterhoeven
> <geert+renesas@xxxxxxxxx>; Chris Paterson <Chris.Paterson2@xxxxxxxxxxx>;
> Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>; linux-
> renesas-soc@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH 2/3] dt-bindings: pwm: rzg2l-gpt: Document renesas,poegs
> property
> 
> On 04/11/2022 12:52, Biju Das wrote:
> > Hi Krzysztof Kozlowski,
> >
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> >> Subject: Re: [PATCH 2/3] dt-bindings: pwm: rzg2l-gpt: Document
> >> renesas,poegs property
> >>
> >> On 04/11/2022 10:59, Biju Das wrote:
> >>> RZ/G2L GPT IP supports output pin disable function by dead time
> >> error
> >>> and detecting short-circuits between output pins.
> >>>
> >>> Add documentation for the optional property renesas,poegs to link a
> >>> pair of GPT IOs with POEG.
> >>>
> >>> Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> >>> ---
> >>>  .../bindings/pwm/renesas,rzg2l-gpt.yaml       | 19
> >> +++++++++++++++++++
> >>>  1 file changed, 19 insertions(+)
> >>>
> >>> diff --git
> >>> a/Documentation/devicetree/bindings/pwm/renesas,rzg2l-gpt.yaml
> >>> b/Documentation/devicetree/bindings/pwm/renesas,rzg2l-gpt.yaml
> >>> index 620d5ae4ae30..32f9deae89e5 100644
> >>> --- a/Documentation/devicetree/bindings/pwm/renesas,rzg2l-gpt.yaml
> >>> +++ b/Documentation/devicetree/bindings/pwm/renesas,rzg2l-gpt.yaml
> >>> @@ -245,6 +245,24 @@ properties:
> >>>    resets:
> >>>      maxItems: 1
> >>>
> >>> +  renesas,poegs:
> >>> +    $ref: "/schemas/types.yaml#/definitions/phandle-array"
> >>
> >> No need for quotes.
> >>
> >>> +    items:
> >>
> >> You miss here maxItems... but if you have just one item, then below
> >> "items" should be " - items"
> >>
> >>> +      items:
> >>> +        - description: phandle to POEG instance that serves the
> >> output disable
> >>> +        - description: An index identifying pair of GPT channels.
> >>> +                       <0> - GPT channels 0 and 1
> >>> +                       <1> - GPT channels 2 and 3
> >>> +                       <2> - GPT channels 4 and 5
> >>> +                       <3> - GPT channels 6 and 7
> >>> +                       <4> - GPT channels 8 and 9
> >>> +                       <5> - GPT channels 10 and 11
> >>> +                       <6> - GPT channels 12 and 13
> >>> +                       <7> - GPT channels 14 and 15
> >>
> >> then this could bave enum or minimum/maximum. Can you try if these
> >> work?
> >
> > Yes, checks are passing with below changes.
> > Will send V2 later once I get feedback for driver changes/ from other
> reviewers.
> >
> > renesas,poegs:
> > -    $ref: "/schemas/types.yaml#/definitions/phandle-array"
> > +    $ref: /schemas/types.yaml#/definitions/phandle-array
> >      items:
> > +      maxItems: 8
> 
> and it might also require minItems: 1

OK will send V2 with these changes.

Cheers,
Biju




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux