Re: [PATCH v28 04/11] soc: mediatek: add mtk-mmsys support for mt8195 vdosys1

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 08/11/2022 20:10, Nícolas F. R. A. Prado wrote:
On Tue, Nov 08, 2022 at 06:46:54PM +0100, Matthias Brugger wrote:
On 07/11/2022 08:22, Nancy.Lin wrote:
[..]
--- a/drivers/soc/mediatek/mtk-mmsys.c
+++ b/drivers/soc/mediatek/mtk-mmsys.c
@@ -80,6 +80,12 @@ static const struct mtk_mmsys_driver_data mt8195_vdosys0_driver_data = {
   	.num_routes = ARRAY_SIZE(mmsys_mt8195_routing_table),
   };
+static const struct mtk_mmsys_driver_data mt8195_vdosys1_driver_data = {
+	.clk_driver = "clk-mt8195-vdo1",
+	.routes = mmsys_mt8195_vdo1_routing_table,
+	.num_routes = ARRAY_SIZE(mmsys_mt8195_vdo1_routing_table),
+};
+
   static const struct mtk_mmsys_driver_data mt8365_mmsys_driver_data = {
   	.clk_driver = "clk-mt8365-mm",
   	.routes = mt8365_mmsys_routing_table,
@@ -292,6 +298,10 @@ static const struct of_device_id of_match_mtk_mmsys[] = {
   		.compatible = "mediatek,mt8195-vdosys0",
   		.data = &mt8195_vdosys0_driver_data,

It seems we are missing a patch in the series. vdosys0 also correct was
never introduced in the driver...

Hi Matthias,

as mentioned in the cover letter, this series is based on the series "Change
mmsys compatible for mt8195 mediatek-drm" [1], which introduces vdosys0. This
compatible entry specifically is added on patch 3 of that series [2].

[1] https://lore.kernel.org/all/20220927152704.12018-1-jason-jh.lin@xxxxxxxxxxxx/

My bad. Thanks for the link. I realized that yesterday but had to leave urgently. I'll have a look on this series now.

Regards,
Matthias

[2] https://lore.kernel.org/all/20220927152704.12018-4-jason-jh.lin@xxxxxxxxxxxx/

Thanks,
Nícolas


   	},
+	{
+		.compatible = "mediatek,mt8195-vdosys1",
+		.data = &mt8195_vdosys1_driver_data,
+	},
   	{
   		.compatible = "mediatek,mt8365-mmsys",
   		.data = &mt8365_mmsys_driver_data,



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux