On Fri, Nov 04, 2022 at 09:09:02AM -0400, Krzysztof Kozlowski wrote: > > I think that spi-cpha/spi-cpol belongs to spi-peripheral-props.yaml just > > as much as the others do. > > > > The distinction "device specific, not controller specific" is arbitrary > > to me. These are settings that the controller has to make in order to > > talk to that specific peripheral. Same as many others in that file. > > Not every fruit is an orange, but every orange is a fruit. You do not > put "color: orange" to schema for fruits. You put it to the schema for > oranges. > > IOW, CPHA/CPOL are not valid for most devices, so they cannot be in > spi-peripheral-props.yaml. Ok, then this patch is not correct either. The "nxp,sja1105*" devices need to have only "spi-cpha", and the "nxp,sja1110*" devices need to have only "spi-cpol".
