Aw: Re: [PATCH v2] dt-bindings: pinctrl: update uart/mmc bindings for MT7986 SoC

[Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>]

Hi

> Gesendet: Dienstag, 25. Oktober 2022 um 20:35 Uhr
> Von: "Krzysztof Kozlowski" <krzysztof.kozlowski@xxxxxxxxxx>
> Betreff: Re: [PATCH v2] dt-bindings: pinctrl: update uart/mmc bindings for MT7986 SoC
>
> On 25/10/2022 03:02, Frank Wunderlich wrote:
> > From: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>
> >
> > Add new splitted uart pins and emmc_51
> >
> > Signed-off-by: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>
>
>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

after talking with MTK for the emmc pinctrl settings (custom pull-up) they suggested me to change
binding to fix other emmc-values and allow multiple (2) uart-items

so on top of this patch

             then:
               properties:
                 groups:
-                  enum: [emmc, emmc_rst, emmc_51]
+                  enum: [emmc_45, emmc_51]
           - if:
               properties:
                 function:
@@ -231,10 +231,12 @@ patternProperties:
             then:
               properties:
                 groups:
-                  enum: [uart1_0, uart1_rx_tx, uart1_cts_rts, uart1_1,
-                         uart1_2_rx_tx, uart1_2_cts_rts, uart1_3_rx_tx,
-                         uart1_3_cts_rts, uart2_0_rx_tx, uart2_0_cts_rts,
-                         uart2_1, uart0, uart1, uart2]
+                  items:
+                    enum: [uart1_0, uart1_rx_tx, uart1_cts_rts, uart1_1,
+                           uart1_2_rx_tx, uart1_2_cts_rts, uart1_3_rx_tx,
+                           uart1_3_cts_rts, uart2_0_rx_tx, uart2_0_cts_rts,
+                           uart2_1, uart0, uart1, uart2]
+                  maxItems: 2

i would squash these changes and send as v3 or should i send an extra-patch?

regards Frank