Hi Krzysztof Kozlowski, Thanks for the feedback. > Subject: Re: [PATCH 2/3] dt-bindings: pwm: rzg2l-gpt: Document > renesas,poegs property > > On 04/11/2022 10:59, Biju Das wrote: > > RZ/G2L GPT IP supports output pin disable function by dead time > error > > and detecting short-circuits between output pins. > > > > Add documentation for the optional property renesas,poegs to link a > > pair of GPT IOs with POEG. > > > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > > --- > > .../bindings/pwm/renesas,rzg2l-gpt.yaml | 19 > +++++++++++++++++++ > > 1 file changed, 19 insertions(+) > > > > diff --git > > a/Documentation/devicetree/bindings/pwm/renesas,rzg2l-gpt.yaml > > b/Documentation/devicetree/bindings/pwm/renesas,rzg2l-gpt.yaml > > index 620d5ae4ae30..32f9deae89e5 100644 > > --- a/Documentation/devicetree/bindings/pwm/renesas,rzg2l-gpt.yaml > > +++ b/Documentation/devicetree/bindings/pwm/renesas,rzg2l-gpt.yaml > > @@ -245,6 +245,24 @@ properties: > > resets: > > maxItems: 1 > > > > + renesas,poegs: > > + $ref: "/schemas/types.yaml#/definitions/phandle-array" > > No need for quotes. OK, I just referred renesas,vsps in [1] as example [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/display/renesas,du.yaml?h=v6.1-rc3#n85 > > > + items: > > You miss here maxItems... but if you have just one item, then below > "items" should be " - items" Max Items is 8, as we have 8 GPT hw channels. Based on HW board design, we should have flexibility to define something like below, renesas,poegs = <&poegga 0>, <&poeggb 1> <&poegga 2> <&poeggd 4>; > > > + items: > > + - description: phandle to POEG instance that serves the > output disable > > + - description: An index identifying pair of GPT channels. > > + <0> - GPT channels 0 and 1 > > + <1> - GPT channels 2 and 3 > > + <2> - GPT channels 4 and 5 > > + <3> - GPT channels 6 and 7 > > + <4> - GPT channels 8 and 9 > > + <5> - GPT channels 10 and 11 > > + <6> - GPT channels 12 and 13 > > + <7> - GPT channels 14 and 15 > > then this could bave enum or minimum/maximum. Can you try if these > work? OK, I will try second items as enum as it is predefined values and Will let you know the results. Cheers, Biju
