On 03/11/2022 14:20, Naresh Solanki wrote: > > > On 03-11-2022 11:31 pm, Krzysztof Kozlowski wrote: >> OK, so indeed there are improvements. >> >> Yet still you did not improve the warnings coming from the binding - >> this does not match your binding. Test the binding and you will see big >> fat warning. > Not sure what I've missed but below is the output: > make dt_binding_check -j1 V=1 > make -f ./scripts/Makefile.build obj=scripts/basic > make -f ./scripts/Makefile.build obj=scripts/dtc > make -f ./scripts/Makefile.build obj=Documentation/devicetree/bindings > dt-extract-example > Documentation/devicetree/bindings/mfd/maxim,max5970.yaml > > Documentation/devicetree/bindings/mfd/maxim,max5970.example.dts > gcc -E > -Wp,-MMD,Documentation/devicetree/bindings/mfd/.maxim_max5970.example.dtb.d.pre.tmp > -nostdinc -I./scripts/dtc/include-prefixes -undef -D__DTS__ -x > assembler-with-cpp -o > Documentation/devicetree/bindings/mfd/.maxim_max5970.example.dtb.dts.tmp > Documentation/devicetree/bindings/mfd/maxim,max5970.example.dts ; > ./scripts/dtc/dtc -o > Documentation/devicetree/bindings/mfd/maxim,max5970.example.dtb -b 0 > -iDocumentation/devicetree/bindings/mfd/ > -i./scripts/dtc/include-prefixes -Wno-avoid_unnecessary_addr_size > -Wno-graph_child_address -Wno-interrupt_provider > -Wno-unique_unit_address -Wunique_unit_address_if_enabled -d > Documentation/devicetree/bindings/mfd/.maxim_max5970.example.dtb.d.dtc.tmp > Documentation/devicetree/bindings/mfd/.maxim_max5970.example.dtb.dts.tmp > ; cat > Documentation/devicetree/bindings/mfd/.maxim_max5970.example.dtb.d.pre.tmp > Documentation/devicetree/bindings/mfd/.maxim_max5970.example.dtb.d.dtc.tmp > > Documentation/devicetree/bindings/mfd/.maxim_max5970.example.dtb.d ; > dt-validate -u ./Documentation/devicetree/bindings -p > ./Documentation/devicetree/bindings/processed-schema.json > Documentation/devicetree/bindings/mfd/maxim,max5970.example.dtb || true > > Didn't get any error or warning on example. > Made sure python package dt-schema is updated as well. Eh, true, but you have there "additionalProperties: true" which are not allowed. This must be false and about leds I commented. False must be in all other places as well. Best regards, Krzysztof
