On 03/11/2022 13:53, Naresh Solanki wrote:
> Hi Krzysztof,
>
> On 03-11-2022 06:43 pm, Krzysztof Kozlowski wrote:
>>> +examples:
>>> + - |
>>> + i2c {
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> + regulator@3a {
>>> + compatible = "maxim,max5978";
>>> + reg = <0x3a>;
>>> + vss1-supply = <&p3v3>;
>>> +
>>> + regulators {
>>> + sw0_ref_0: SW0 {
>> No improvements here.
> I've addressed 4 space indentation, bindings are matched, compatible is
> moved to first, then reg then the rest.
OK, so indeed there are improvements.
Yet still you did not improve the warnings coming from the binding -
this does not match your binding. Test the binding and you will see big
fat warning.
Best regards,
Krzysztof
