On 03/11/2022 12:06, richard.yu@xxxxxxx wrote: > From: Richard Yu <richard.yu@xxxxxxx> > Subject: Drop redundant second "binding" word. > Create documentation for the hpe,gxp-udc binding to support access to > the virtual USB device. > > Signed-off-by: Richard Yu <richard.yu@xxxxxxx> > --- > .../devicetree/bindings/usb/hpe,gxp-udc.yaml | 57 +++++++++++++++++++ > 1 file changed, 57 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/hpe,gxp-udc.yaml > > diff --git a/Documentation/devicetree/bindings/usb/hpe,gxp-udc.yaml b/Documentation/devicetree/bindings/usb/hpe,gxp-udc.yaml > new file mode 100644 > index 000000000000..f1ec4df8c3d3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/hpe,gxp-udc.yaml > @@ -0,0 +1,57 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/usb/hpe,gxp-udc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: HPE GXP Gadget Universal Device Controller (UDC) > + > +maintainers: > + - Richard Yu <richard.yu@xxxxxxx> > + - Jean-Marie Verdun <verdun@xxxxxxx> > + - Nick Hawkins <nick.hawkins@xxxxxxx> > + > +properties: > + compatible: > + const: hpe,gxp-udc > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + vdevnum: > + description: > + virtual device number. That's unusual property... Why numbering devices is part of DT (hardware description)? > + > + fepnum: > + description: > + number of the flexible end-points this device is needed. Similar question. BTW, if you end sentence with '.', it means it is an sentence, so you need to start it with capital letter. > + > + hpe,syscon-phandle: phandle is redudant. You need rather specific name, so "hpe,ehci-syscon" or whatever it is. > + $ref: '/schemas/types.yaml#/definitions/phandle' No quotes. > + description: > + Phandle to the gxp vEHCI controller access vDevice registers. Drop "Phandle to" Isn't "gxp" a GXP? > + > +required: > + - compatible > + - reg > + - interrupts > + - vdevnum > + - fepnum > + - hpe,syscon-phandle > + > +additionalProperties: false > + > +examples: > + - | > + udc@80401000 { Node name "usb", I think it is more popular for USB controllers. > + compatible = "hpe,gxp-udc"; > + reg = <0x80401000 0x1000>; > + interrupts = <13>; > + interrupt-parent = <&vic1>; > + vdevnum = <0>; > + fepnum = <7>; > + hpe,syscon-phandle = <&udc_system_controller>; > + }; Best regards, Krzysztof
