On 3.11.2022 17:12, Florian Fainelli wrote:
On 11/3/2022 9:02 AM, Rafał Miłecki wrote:
On 3.11.2022 16:31, Florian Fainelli wrote:
On 11/3/2022 3:24 AM, Rafał Miłecki wrote:
From: Rafał Miłecki <rafal@xxxxxxxxxx>
String "nand" was never a valid interrupt name. It was never documented
and never used in Linux or U-Boot driver. It most likely comes from a
copy & paste mistake ("nand" is used in "reg-names").
The whole "interrupt-names" property is optional and can be skipped.
How about we just fix the binding document instead? Deciding the fate of a property based upon client programs of the DTS using it is a weak argument IMHO.
It's not a matter of client programs.
Binding clearly says that the first interrupt is "NAND CTLRDY interrupt".
Please check: Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml
The binding is trying to capture all of the existing conditions that are present in Linux's tree but it is not actually specific enough for instance flash_dma_done and flash_edu_done are mutually exclusive and depend upon the controller's generation. Something that ought to be fixed as a separate patch.
In that case binding it wrong and has to be fixed first.
In this case I'll work on the binding first before cleaning DTS files.
Please drop this patch for now.
