Re: [PATCH] ARM: dts: bcm63138: drop invalid "nand" interrupt name

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 3.11.2022 16:31, Florian Fainelli wrote:
On 11/3/2022 3:24 AM, Rafał Miłecki wrote:
From: Rafał Miłecki <rafal@xxxxxxxxxx>

String "nand" was never a valid interrupt name. It was never documented
and never used in Linux or U-Boot driver. It most likely comes from a
copy & paste mistake ("nand" is used in "reg-names").

The whole "interrupt-names" property is optional and can be skipped.

How about we just fix the binding document instead? Deciding the fate of a property based upon client programs of the DTS using it is a weak argument IMHO.

It's not a matter of client programs.


Binding clearly says that the first interrupt is "NAND CTLRDY interrupt".
Please check: Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml

Other interrupts are described as well. It's just "interrupts-names" that
are optional.



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux