On 03.11.2022 13:35, Krzysztof Kozlowski wrote: > On 02/11/2022 09:06, Aakarsh Jain wrote: >> commit "5441e9dafdfc6dc40fa" which adds mfc v7 support for > Please run scripts/checkpatch.pl and fix reported warnings. > >> Exynos3250 and used the same compatible string as used by >> Exynos5240 but both the IPs are a bit different in terms of >> IP clock. >> Lets add variant driver data based on the new compatible string >> "samsung,exynos3250-mfc" for Exynos3250 SoC. > Aren't you just missing the clock on Exynos3250? Nope, the Exynos3250 variant indeed has only one clock and the driver code simply ignored the -ENOENT error while getting the clocks, see the code in drivers/media/platform/samsung/s5p-mfc/s5p_mfc_pm.c, so it worked fine even without it. IMHO it is a good idea to clean this up. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland
