Exynos3250 uses the same compatible as Exynos5420, but both the MFC IPs found in these SoC are different interms of clock property. So using same compatible for both SoC is not correct. Lets have a separate compatible for Exynos3250 and Exynos5420 to differentiate these SoCs. Suggested-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx> Signed-off-by: Aakarsh Jain <aakarsh.jain@xxxxxxxxxxx> --- Documentation/devicetree/bindings/media/s5p-mfc.txt | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) We are already in process of converting this txt file to yaml. https://patchwork.kernel.org/project/linux-media/patch/ 20221011122516.32135-2-aakarsh.jain@xxxxxxxxxxx/ modifying this txt binding for completeness. diff --git a/Documentation/devicetree/bindings/media/s5p-mfc.txt b/Documentation/devicetree/bindings/media/s5p-mfc.txt index aa54c8159d9f..4ff1898e5a51 100644 --- a/Documentation/devicetree/bindings/media/s5p-mfc.txt +++ b/Documentation/devicetree/bindings/media/s5p-mfc.txt @@ -11,9 +11,10 @@ Required properties: (a) "samsung,mfc-v5" for MFC v5 present in Exynos4 SoCs (b) "samsung,mfc-v6" for MFC v6 present in Exynos5 SoCs (c) "samsung,mfc-v7" for MFC v7 present in Exynos5420 SoC - (d) "samsung,mfc-v8" for MFC v8 present in Exynos5800 SoC - (e) "samsung,exynos5433-mfc" for MFC v8 present in Exynos5433 SoC - (f) "samsung,mfc-v10" for MFC v10 present in Exynos7880 SoC + (d) "samsung,exynos3250-mfc" for MFC v7 present in Exynos3250 SoC + (e) "samsung,mfc-v8" for MFC v8 present in Exynos5800 SoC + (f) "samsung,exynos5433-mfc" for MFC v8 present in Exynos5433 SoC + (g) "samsung,mfc-v10" for MFC v10 present in Exynos7880 SoC - reg : Physical base address of the IP registers and length of memory mapped region. -- 2.17.1
