On 31/10/2022 19:29, Melody Olvera wrote: > > > On 10/27/2022 8:29 AM, Krzysztof Kozlowski wrote: >> On 26/10/2022 15:05, Melody Olvera wrote: >>> Many of the *-virt compatible devices do not have a reg field >>> so remove it as required from the bindings. >> and some virt have it... This should be probably separate binding or if >> the list is small - allOf:if:then. > I attempted this; however I'm still seeing failures in dtb_check. I've added this > to the binding; does this look correct? > allOf: > - $ref: qcom,rpmh-common.yaml# > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,qdu1000-clk-virt > + - qcom,qdu1000-mc-virt > + > + then: > + required: > + - compatible No, because we talk about reg, not compatible. You should not require reg instead for some compatibles... but then the schema is getting complicated. It's difficult to give you recommendation because I do not know what are all these "virt" interconnects. Why some have unit address, why some do not? Best regards, Krzysztof
