On 28/10/2022 05:33, Jon Hunter wrote:
>>> + ucsi_ccg: ucsi_ccg@8 {
>>
>> No underscores in node names.
>>
>>> + compatible = "cypress,cypd4226";
>>> + cypress,firmware-build = "gn";
>>> + interrupt-parent = <&gpio>;
>>> + interrupts = <TEGRA234_MAIN_GPIO(Y, 4) IRQ_TYPE_LEVEL_LOW>;
>>> + reg = <0x08>;
>>> + status = "okay";
>>
>> The pattern of redefining full path in Tegra is confusing - I have no
>> clue which of these status=okay are correct which are redundant.
>>
>> Do you?
>
> I understand you may not like this approach, however, this comment is
> not really relevant to just this patch, but a general comment. But yes
> we will ensure that this is correct.
>
Just to clarify - this status looks redundant, but I have no way to tell
for sure...
Best regards,
Krzysztof
