On Thu, Oct 27, 2022 at 09:10:20PM +0200, Michael Walle wrote: > If one would a new tagger you'd need to add it to > dsa_tag_proto_names[] as well as adding the tagger source file. Thus, > two places to keep in sync. And you don't have all the information in > one place, e.g. the tagger module. The name of the tagger as used in > sysfs or device tree is then in the core. Just wanted to point that out. > After all it's up to you as the maintainer to decide ;) True, there are already 2 places you need to keep in sync, you already need to add the tagger id to include/net/dsa.h (twice). The header is shared between taggers, the DSA core and device drivers. A third place would indeed be a bit too much. Actually I came to like your idea with 2 modaliases. I prepared a patch set and I'm in the process of testing it (need to rebuild everything with modules, which I usually skip). If it works, I'll post it as an RFC soon.
