On 27/10/2022 13:03, Russell King (Oracle) wrote: > Add the DT binding for the Apple Mac System Management Controller GPIOs. > > Signed-off-by: Russell King (Oracle) <rmk+kernel@xxxxxxxxxxxxxxx> > --- > .../devicetree/bindings/gpio/gpio-macsmc.yaml | 28 +++++++++++++++++++ > 1 file changed, 28 insertions(+) > create mode 100644 Documentation/devicetree/bindings/gpio/gpio-macsmc.yaml > > diff --git a/Documentation/devicetree/bindings/gpio/gpio-macsmc.yaml b/Documentation/devicetree/bindings/gpio/gpio-macsmc.yaml > new file mode 100644 > index 000000000000..a3883d62292d > --- /dev/null > +++ b/Documentation/devicetree/bindings/gpio/gpio-macsmc.yaml Filename based on compatible, so "apple,smc-gpio.yaml" > @@ -0,0 +1,28 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/gpio/gpio-macsmc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Apple Mac System Management Controller GPIO > + > +maintainers: > + - Hector Martin <marcan@xxxxxxxxx> > + > +description: > + This describes the binding for the Apple Mac System Management Controller Drop "This describes the binding for" > + GPIO block. > + > +properties: > + compatible: > + allOf: That's not proper syntax. Look at other examples (e.g. Apple bindings) doing it. Probably you wanted items here. > + - enum: > + - apple,t8103-smc > + - const: apple,smc-gpio > + > + gpio-controller: true > + > + '#gpio-cells': > + const: 2 Missing required properties. Start from new bindings or example-schema. > + > +additionalProperties: false Missing example, it's necessary to validate these. Best regards, Krzysztof
