On 27/10/2022 04:20, Yinbo Zhu wrote: > You can find these code has a change in this code conext. I have a > feedback on this code. but I mistakenly thought helper is dev_err_probe. > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > pctrl->reg_base = devm_ioremap_resource(dev, res); > if (IS_ERR(pctrl->reg_base)) > - return PTR_ERR(pctrl->reg_base); > + return dev_err_probe(pctrl->dev, PTR_ERR(pctrl->reg_base), > + "unable to map I/O memory"); > > raw_spin_lock_init(&pctrl->lock); > >> >> There is a helper combining two calls into one. Grep for it in headers >> and use it. >> > You said is that use "devm_platform_get_and_ioremap_resource" as a > helper? sorry, I will do it. I believe the helper is devm_platform_ioremap_resource(), but I never remember the names so just check in the sources. Best regards, Krzysztof
