On Wed, Oct 26, 2022 at 12:47:04PM -0500, Rob Herring wrote: > On Mon, Oct 24, 2022 at 10:03:55PM -0700, Colin Foster wrote: > > Several bindings for ethernet switches are available for non-dsa switches > > by way of ethernet-switch.yaml. Remove these duplicate entries and utilize > > the common bindings for the VSC7514. > > > > Signed-off-by: Colin Foster <colin.foster@xxxxxxxxxxxxxxxx> > > Suggested-by: Vladimir Oltean <olteanv@xxxxxxxxx> > > --- > > .../bindings/net/mscc,vsc7514-switch.yaml | 36 +------------------ > > 1 file changed, 1 insertion(+), 35 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml b/Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml > > index ee0a504bdb24..1703bd46c3ca 100644 > > --- a/Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml > > +++ b/Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml > > @@ -19,11 +19,8 @@ description: | > > packet extraction/injection. > > > > properties: > > - $nodename: > > - pattern: "^switch@[0-9a-f]+$" > > - > > compatible: > > - const: mscc,vsc7514-switch > > + $ref: ethernet-switch.yaml# > > ??? 'compatible' is a node? I need to look more into this. The compatible string should remain mscc,vsc7514-switch, but I think the pattern properties should probably be updated to "^(ethernet-)switch@[0-9a-f]+$" to match ethernet-switch.yaml. I didn't think the ethernet-switch.yaml could be at the top level for the 7514, but I must have been mistaken. Either way - not under compatible as you're pointing out. Much appreciated. > > Rob
