> > +EXPORT_SYMBOL(gsw1xx_shutdown); > > 1. EXPORT_SYMBOL_GPL > 2. Why do you do it in the first place? It's one driver, no need for > building two modules. Same applies to other places. At some point, there is likely to be SPI and UART support. The communication with the chip and the core driver will then be in separate modules. But i agree this is not needed at the moment when it is all linked into one. Andrew
