On 20/10/2022 21:09, Yinbo Zhu wrote: > Add the loongson2 High Precision Event Timer (HPET) binding > with DT schema format using json-schema. > > Signed-off-by: Yinbo Zhu <zhuyinbo@xxxxxxxxxxx> > --- > Change in v3: > 1. Update dts that base on common clock framework. > > .../bindings/timer/loongson,ls2k-hpet.yaml | 50 +++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 51 insertions(+) > create mode 100644 Documentation/devicetree/bindings/timer/loongson,ls2k-hpet.yaml > > diff --git a/Documentation/devicetree/bindings/timer/loongson,ls2k-hpet.yaml b/Documentation/devicetree/bindings/timer/loongson,ls2k-hpet.yaml > new file mode 100644 > index 000000000000..01656048858a > --- /dev/null > +++ b/Documentation/devicetree/bindings/timer/loongson,ls2k-hpet.yaml > @@ -0,0 +1,50 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/timer/loongson,ls2k-hpet.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Loongson2 High Precision Event Timer (HPET) > + > +maintainers: > + - Yinbo Zhu <zhuyinbo@xxxxxxxxxxx> > + > +properties: > + compatible: > + const: loongson,ls2k-hpet > + > + reg: > + maxItems: 1 > + > + clocks: > + items: > + - description: SoC apb clock > + > + clock-names: > + items: > + - const: apb_clk Just: apb > + > + interrupts: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - interrupts > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/loongson,ls2k-clk.h> Your patchset is now untestable/unapplicable because you have a dependency. You need to explain the dependencies in the cover letter or in the patch changelog (---). Best regards, Krzysztof