Thanks for the review. All the changes will be updated in the next patchset except the power-domain-name. On 10/24/22 22:54, Rob Herring wrote: > External email: Use caution opening links or attachments > > >> +description: >> + The Tegra XHCI controller supports both USB 2.0 HighSpeed/FullSpeed and >> + USB 3.1 SuperSpeed protocols. >> + >> +maintainers: >> + - Wayne Chang <waynec@xxxxxxxxxx> >> + > > Ref to usb-xhci.yaml? Or usb-hcd.yaml. > It should be usb-xhci.yaml. thanks. >> + power-domain-names: >> + items: >> + - const: xusb_host >> + - const: xusb_ss > > Drop 'xusb_'. The properties are constant and we use the name to get the power domain. tegra->genpd_dev_host = dev_pm_domain_attach_by_name(dev, "xusb_host"); tegra->genpd_dev_ss = dev_pm_domain_attach_by_name(dev, "xusb_ss"); we might not be able to drop the xusb_ thanks, Wayne.