On 24/10/2022 14:53, Rob Herring wrote: > On Sat, Oct 22, 2022 at 12:05:15PM -0400, Krzysztof Kozlowski wrote: >> On 21/10/2022 13:10, Sebastian Reichel wrote: >>> The queue configuration is referenced by snps,mtl-rx-config and >>> snps,mtl-tx-config. Most in-tree DTs put the referenced object >>> as child node of the dwmac node. >>> >>> This adds proper description for this setup, which has the >>> advantage of properly making sure only known properties are >>> used. >>> >>> Signed-off-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx> >>> --- >>> .../devicetree/bindings/net/snps,dwmac.yaml | 154 ++++++++++++------ >>> 1 file changed, 108 insertions(+), 46 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml >>> index 13b984076af5..0bf6112cec2f 100644 >>> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml >>> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml >>> @@ -167,56 +167,118 @@ properties: >>> snps,mtl-rx-config: >>> $ref: /schemas/types.yaml#/definitions/phandle >>> description: >>> - Multiple RX Queues parameters. Phandle to a node that can >>> - contain the following properties >>> - * snps,rx-queues-to-use, number of RX queues to be used in the >>> - driver >>> - * Choose one of these RX scheduling algorithms >>> - * snps,rx-sched-sp, Strict priority >>> - * snps,rx-sched-wsp, Weighted Strict priority >>> - * For each RX queue >>> - * Choose one of these modes >>> - * snps,dcb-algorithm, Queue to be enabled as DCB >>> - * snps,avb-algorithm, Queue to be enabled as AVB >>> - * snps,map-to-dma-channel, Channel to map >>> - * Specifiy specific packet routing >>> - * snps,route-avcp, AV Untagged Control packets >>> - * snps,route-ptp, PTP Packets >>> - * snps,route-dcbcp, DCB Control Packets >>> - * snps,route-up, Untagged Packets >>> - * snps,route-multi-broad, Multicast & Broadcast Packets >>> - * snps,priority, bitmask of the tagged frames priorities assigned to >>> - the queue >>> + Multiple RX Queues parameters. Phandle to a node that >>> + implements the 'rx-queues-config' object described in >>> + this binding. >>> + >>> + rx-queues-config: >> >> If this field is specific to this device, then you need vendor prefix: >> snps,rq-queues-config > > Not for a node name... Right. Best regards, Krzysztof
