Re: [PATCH v4 8/8] power: supply: fix wrong interpretation of register value

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 24/10/22 16:18, Andy Shevchenko wrote:
On Mon, Oct 24, 2022 at 5:07 PM saravanan sekar <sravanhome@xxxxxxxxx> wrote:

On 24/10/22 15:50, Andy Shevchenko wrote:
On Mon, Oct 24, 2022 at 4:50 PM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
On Mon, Oct 24, 2022 at 4:28 PM Saravanan Sekar <sravanhome@xxxxxxxxx> wrote:

fix wrong interpretation of bitwise as hex

Maybe you can replace 0x with 0b instead?


Ok, I consider to changes as "fix the register value interpretation as
0x instead of 0b" does it fits !!

No, it doesn't because there is no evidence of 0b in use. I suggested
to use 0b in the code (as the part of your change) instead of
switching to hex.


Ok, I guess re-phrase of commit message shall solve the conflict. I feel use of 0x in code is fine.

I will edit the commit message as "fix the switch case to match the register values"


Thanks,
Saravanan



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux