On 19/10/2022 11:48, Doug Anderson wrote: > Hi, > > On Tue, Oct 18, 2022 at 5:14 PM Krzysztof Kozlowski > <krzysztof.kozlowski@xxxxxxxxxx> wrote: >> >> Convert Qualcomm SC7180 pin controller bindings to DT schema. Keep the >> parsing of pin configuration subnodes consistent with other Qualcomm >> schemas (children named with '-state' suffix, their children with >> '-pins'). >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >> Reviewed-by: Rob Herring <robh@xxxxxxxxxx> >> >> --- >> >> Changes since v2: >> 1. Drop entire drive-strength (not needed, brought by common TLMM >> schema). >> >> Changes since v1: >> 1. Drop default:2 for drive strength >> 2. Add Rb tag. >> >> Cc: Doug Anderson <dianders@xxxxxxxxxxxx> >> --- >> .../bindings/pinctrl/qcom,sc7180-pinctrl.txt | 187 ------------------ >> .../bindings/pinctrl/qcom,sc7180-pinctrl.yaml | 158 +++++++++++++++ >> 2 files changed, 158 insertions(+), 187 deletions(-) > > Looks great now. > > Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx> Thanks > > Will you also send out separate patches to fix up the "drive strength" > for all the other Qualcomm boards. They all have the same problem. The > drive strength never defaults to 2 and always gets left at whatever > the BIOS leaves it at unless it's specified. If you mean - other bindings for Qualcomm - then answer is yes. Several things are already applied and will pop-up in tomorrow's next: https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux-dt.git/log/?h=next/qcom-pinctrl I'll go in spare time with rest of bindings. Best regards, Krzysztof
