> -----Original Message----- > From: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx> > Sent: Tuesday, October 18, 2022 3:41 AM > To: tharvey@xxxxxxxxxxxxx > Cc: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx>; Shawn Guo > <shawnguo@xxxxxxxxxx>; Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>; > devicetree@xxxxxxxxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx>; Pengutronix > Kernel Team <kernel@xxxxxxxxxxxxxx>; Fabio Estevam <festevam@xxxxxxxxx>; > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; Jun Li <jun.li@xxxxxxx> > Subject: Re: [PATCH v3 1/1] arm64: dts: tqma8mpql: add USB DR support > > Hello Tim, > > On 17.10.22 21:30, Tim Harvey wrote: > > On Fri, Oct 14, 2022 at 7:18 AM Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx> > wrote: > >> > >> Hello Alexander, > >> > >> On 05.09.22 09:37, Alexander Stein wrote: > >>> + pinctrl_usb0: usb0grp { > >>> + fsl,pins = <MX8MP_IOMUXC_GPIO1_IO13__USB1_OTG_OC > 0x1c0>, > >>> + <MX8MP_IOMUXC_GPIO1_IO12__USB1_OTG_PWR > 0x1c0>; > >>> + }; > >>> + > >>> + pinctrl_usbcon0: usb0congrp { > >>> + fsl,pins = <MX8MP_IOMUXC_GPIO1_IO10__GPIO1_IO10 > 0x1c0>; > >>> + }; > >> > >> I am wondering: You can mux for MX8MP_IOMUXC_GPIO1_IO10__USB1_OTG_ID, > >> why did you decide against using the hardware function here? > >> > > > > Ahmad, > > > > The IMX8MP USB OTG_ID pins are internally not connected. I can't > > recall where this is mentioned but due to this they can not be used to > > select host/device mode. > > Thanks for the info. Do you know if this issue exists with the i.MX8MN as > well? A colleague had trouble bringing up the OTG_ID HW function and I assume > it may be the same issue. I am unsure though, because the > imx8mn-tqma8mqnl-mba8mx.dts muxes the pad as OTG_ID. No, iMX8MN is completely different IP(USB2 only) than iMX8MP, iMX8MN has *OTG* inside so the ID functionality should be fine, what's the trouble you colleague had? Li Jun > > Cheers, > Ahmad > > > > > Best Regards, > > > > Tim > > > > > -- > Pengutronix e.K. | | > Steuerwalder Str. 21 | > https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.pe > ngutronix.de%2F&data=05%7C01%7Cjun.li%40nxp.com%7Cac32a99803dc4e710 > 4d408dab0777a15%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6380163244 > 44837508%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLC > JBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=4TFBorG%2BucyYuy > HrwhTDxjz4GV3%2FsCaHzx7i4cdw5Zw%3D&reserved=0 | > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |