Hi Sebastian, On 10/21/2014 01:53 AM, Sebastian Hesselbarth wrote: > This patch series deals with a removing a IP feature that can be found > on all currently supported Marvell Ethernet IP (pxa168_eth, mv643xx_eth, > mvneta). The MAC IP allows to automatically perform PHY auto-negotiation > without software interaction. > > However, this feature (a) fundamentally clashes with the way libphy works > and (b) is unable to deal with quirky PHYs that require special treatment. > In this series, pxa168_eth driver is rewritten to completely disable that > feature and properly deal with libphy provided PHYs. > > This is the real patch set after an RFT sent earlier. Unfortunately, there > was no testing from MMP/gplug but there was for BG2Q. However, it still > would be great to get a Tested-by on gplug. Also, this patch set is now > rebased on v3.18-rc1. As usual, a branch on top of v3.18-rc1 can be found at > > git://git.infradead.org/users/hesselba/linux-berlin.git devel/bg2-bg2cd-eth-v1 > > Patches 1-5 should go through David's net tree, I'll pick up the DT patches > 6-9. > > Compared to the RFT, there have been some changes: > - added phy-connection-type property to BG2Q PHY DT node > - bail out from pxa168_eth_adjust_link when there is no change in > PHY parameters. Also, add a call to phy_print_status. > > Patch 1 adds support for Marvell 88E3016 FastEthernet PHY that is also > integrated in Marvell Berlin BG2/BG2CD SoCs. > > Patch 2 allows to pass phy_interface_t on pxa168_eth platform_data that > is only used by mach-mmp/gplug. From the board setup, I guessed gplug's > PHY is connected via RMII. The patch still isn't even compile tested. > > Patches 3-5 prepare proper libphy handling and finally remove all in-driver > PHY mangling related to the feature explained above. > > Patches 6-9 add corresponding ethernet DT nodes to BG2, BG2CD, add a > phy-connection-type property to BG2Q and enable ethernet on BG2-based Sony > NSZ-GS7. I have tested all this on GS7 successfully with ip=dhcp on 100M FD. Besides the misplacement of the 'phy-connection-type' as reported by Sergei, this looks good to me: Reviewed-by: Florian Fainelli <f.fainelli@xxxxxxxxx> Thanks! > > Antoine Ténart (1): > ARM: berlin: Add phy-connection-type to BG2Q PHY > > Sebastian Hesselbarth (8): > phy: marvell: Add support for 88E3016 FastEthernet PHY > net: pxa168_eth: Provide phy_interface mode on platform_data > net: pxa168_eth: Prepare proper libphy handling > net: pxa168_eth: Remove HW auto-negotiaion > net: pxa168_eth: Remove in-driver PHY mangling > ARM: berlin: Add BG2 ethernet DT nodes > ARM: berlin: Add BG2CD ethernet DT nodes > ARM: berlin: Enable ethernet on Sony NSZ-GS7 > > arch/arm/boot/dts/berlin2-sony-nsz-gs7.dts | 2 + > arch/arm/boot/dts/berlin2.dtsi | 36 +++++ > arch/arm/boot/dts/berlin2cd.dtsi | 36 +++++ > arch/arm/boot/dts/berlin2q.dtsi | 1 + > arch/arm/mach-mmp/gplugd.c | 2 + > drivers/net/ethernet/marvell/pxa168_eth.c | 248 ++++++++++++----------------- > drivers/net/phy/marvell.c | 46 ++++++ > include/linux/marvell_phy.h | 1 + > include/linux/pxa168_eth.h | 1 + > 9 files changed, 225 insertions(+), 148 deletions(-) > > --- > Cc: "David S. Miller" <davem@xxxxxxxxxxxxx> > Cc: "Antoine Ténart" <antoine.tenart@xxxxxxxxxxxxxxxxxx> > Cc: Florian Fainelli <f.fainelli@xxxxxxxxx> > Cc: Eric Miao <eric.y.miao@xxxxxxxxx> > Cc: Haojian Zhuang <haojian.zhuang@xxxxxxxxx> > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > Cc: netdev@xxxxxxxxxxxxxxx > Cc: devicetree@xxxxxxxxxxxxxxx > Cc: linux-kernel@xxxxxxxxxxxxxxx > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
