On 11/10/2022 10:55, Biju Das wrote: > >>> .../bindings/mfd/renesas,rz-mtu3.yaml | 305 >> ++++++++++++++++++ >>> 1 file changed, 305 insertions(+) >>> create mode 100644 >>> Documentation/devicetree/bindings/mfd/renesas,rz-mtu3.yaml >> >> This should not be in MFD. Just because some device has few features, >> does not mean it should go to MFD... Choose either timer or pwm. > > MFD is for multifunction device. This IP supports multiple functions > like timer, pwm, clock source/events. That is the reason I have added > here. MFD is core which provides register access for client devices. > > For me moving it to pwm or counter is not a big problem. > Why do you think it cannot be MFD? Because it makes MFD a dump for everything where author did not want to think about real device aspects, but instead represented driver design (MFD driver). MFDs are pretty often combining unrelated features, e.g. PMICs which have wakeup and system power control, regulator, 32 kHz clocks, RTC and some USB connector. Just because you will have clocksource driver, PWM driver and timer driver does not make it a MFD. Best regards, Krzysztof
