Hi, On Monday 13 October 2014 01:46 PM, Gabriel Fernandez wrote: > Hi Valdis, > Thanks for your remark. > > Concerning multiple writing in MIPHY_PLL_SBR_1, the writing of the > first 0 it's to be sure there is no previous request. > Then we take account new setting by writing 0x02. > And then we make it 0 to make sure there is no other pending requests. > > I added comments and macro to be more clear (see the code below). > > > Hi Kishon, > > Do you want a new patch set (v4), or i wait other remarks from you ? Apart from my comment below and for adding a common dt header file, rest of it looks fine. > > > for (val = 0; val < 2; val++) { What is "2" here? Lets add a macro for it. Thanks Kishon -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html