On Fri, Oct 07, 2022 at 12:11:15PM -0700, Tadeusz Struk wrote:
> Add a new fdt_get_property_by_offset_w helper function.
> It is a wrapper on the fdt_get_property_by_offset() cuntion
> that returns a writable pointer to a property at a given offset.
>
> Signed-off-by: Tadeusz Struk <tadeusz.struk@xxxxxxxxxx>
Sorty for the delay. There's one nit here:
> ---
> libfdt/libfdt.h | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/libfdt/libfdt.h b/libfdt/libfdt.h
> index a7f432c..cddc2d6 100644
> --- a/libfdt/libfdt.h
> +++ b/libfdt/libfdt.h
> @@ -660,6 +660,13 @@ int fdt_next_property_offset(const void *fdt, int offset);
> const struct fdt_property *fdt_get_property_by_offset(const void *fdt,
> int offset,
> int *lenp);
> +static inline struct fdt_property *fdt_get_property_by_offset_w(const void *fdt,
This should be void *fdt, not const void *fdt: the function shouldn't
let you get a writable pointer into the fdt if you didn't have a
writable pointer to the fdt to begin with.
> + int offset,
> + int *lenp)
> +{
> + return (struct fdt_property *)(uintptr_t)
> + fdt_get_property_by_offset(fdt, offset, lenp);
> +}
>
> /**
> * fdt_get_property_namelen - find a property based on substring
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
Attachment:
signature.asc
Description: PGP signature
