On 07/10/2022 07:53, Delphine CC Chiu wrote: > Add linux device tree entry related to > greatlakes specific devices connected to BMC SoC. > > --- > --- v3 - Add documentation of board compatible (bindings) > --- - Add board compatible > --- - Remove the bootargs > --- - Revise the DTS node name > --- > --- v2 - Add binding document > --- > --- v1 - Initial draft This is a friendly reminder during the review process. It seems my previous comments were not fully addressed. Maybe my feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them. Thank you. > --- > > Signed-off-by: Bonnie Lo <Bonnie_Lo@xxxxxxxxxx> > --- > arch/arm/boot/dts/Makefile | 1 + > .../dts/aspeed-bmc-facebook-greatlakes.dts | 241 ++++++++++++++++++ You need to document the binding. I think you already did, but then submitted without it. Read the process: https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst Best regards, Krzysztof
