On Tue, Oct 4, 2022 at 8:32 AM Conor Dooley <conor.dooley@xxxxxxxxxxxxx> wrote: > > On Tue, Oct 04, 2022 at 08:26:01AM +0100, Lad, Prabhakar wrote: > > Hi Geert, > > > > Thank you for the review. > > > > On Tue, Oct 4, 2022 at 7:42 AM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > > > > > > Hi Prabhakar, > > > > > > On Tue, Oct 4, 2022 at 12:32 AM Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote: > > > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > > > > > > > Add DT binding documentation for L2 cache controller found on RZ/Five SoC. > > > > > > > > The Renesas RZ/Five microprocessor includes a RISC-V CPU Core (AX45MP > > > > Single) from Andes. The AX45MP core has an L2 cache controller, this patch > > > > describes the L2 cache block. > > > > > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > > > > > Thanks for your patch! > > > > > > > --- /dev/null > > > > +++ b/Documentation/devicetree/bindings/soc/renesas/r9a07g043f-l2-cache.yaml > > > > > > Not andestech,ax45mp-cache.yaml? > > > > > I wasn't sure as we were including this in soc/renesas so named it as > > r9a07g043f-l2-cache.yaml if there are no issues I'll rename it > > andestech,ax45mp-cache.yaml. > > I may be guilty of suggesting soc/renesas in the first place, but should > this maybe be in soc/andestech? I have no skin in the game, so at the > end of the day it doesnt matter to me, but I would imagine that you're > not going to be the only users of this l2 cache? Or is it a case of "we > will deal with future users when said future users arrive"? But either > way, naming it after the less specific compatible makes more sense to > me. > As there aren't any Andestech SoCs upstream, I am in favour of keeping in soc/renesas for maintenance. If in future there comes a new soc from Andestech (which will go into soc/andestech) we will have to split the maintenance work. But anyway if there will be any users of L2 cache we could always provide a config option which can be used by other SoCs. Said that I'll let Geert decide on this. Cheers, Prabhakar
