On Mon, 3 Oct 2022 at 21:47, Melody Olvera <quic_molvera@xxxxxxxxxxx> wrote: > > > On 10/1/2022 4:24 AM, Krzysztof Kozlowski wrote: > > On 01/10/2022 05:03, Melody Olvera wrote: > >> Add device tree bindings for global clock controller on QDU1000 and > >> QRU1000 SoCs. > >> > >> Signed-off-by: Melody Olvera <quic_molvera@xxxxxxxxxxx> > >> --- > >> .../bindings/clock/qcom,gcc-qdru1000.yaml | 74 ++++++++ > >> include/dt-bindings/clock/qcom,gcc-qdru1000.h | 170 ++++++++++++++++++ > >> 2 files changed, 244 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/clock/qcom,gcc-qdru1000.yaml > >> create mode 100644 include/dt-bindings/clock/qcom,gcc-qdru1000.h > >> > >> diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-qdru1000.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-qdru1000.yaml > >> new file mode 100644 > >> index 000000000000..d92f558d547c > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-qdru1000.yaml > >> @@ -0,0 +1,74 @@ > >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > >> +%YAML 1.2 > >> +--- > >> +$id: http://devicetree.org/schemas/clock/qcom,gcc-qdru.yaml# > >> +$schema: http://devicetree.org/meta-schemas/core.yaml# > >> + > >> +title: Qualcomm Global Clock & Reset Controller Binding for QDU1000 and QRU1000 > > Drop "Binding" > > Will do in v2. > > > > >> + > >> +maintainers: > >> + - Melody Olvera <quic_molvera@xxxxxxxxxxx> > >> + > >> +description: | > >> + Qualcomm global clock control module which supports the clocks, resets and > >> + power domains on QDU1000 and QRU1000 > >> + > >> + See also: > >> + - dt-bindings/clock/qcom,gcc-qdru1000.h > > Full path > Understood. > > > >> + > >> +properties: > >> + compatible: > >> + enum: > >> + - qcom,gcc-qdu1000 > >> + - qcom,gcc-qru1000 > >> + > >> + clocks: > >> + items: > >> + - description: Board XO source > >> + - description: Sleep clock source > >> + - description: PCIE 0 Pipe clock source (Optional clock) > > Skip "Optional clock" > > > >> + - description: PCIE 0 Phy Auxiliary clock source (Optional clock) > >> + - description: USB3 Phy wrapper pipe clock source (Optional clock) > >> + minItems: 2 > >> + > >> + clock-names: > >> + items: > >> + - const: bi_tcxo > >> + - const: sleep_clk > >> + - const: pcie_0_pipe_clk # Optional clock > > Skip "Optional clock" > > Will remove all optional clock instances. Drop the 'optional clock' words, not the clocks themselves. See existing examples, which have optional clocks. -- With best wishes Dmitry