On 28/09/2022 14:39, Lin, Meng-Bo wrote: > The smartphones below are using the MSM8916 SoC, > which are released in 2015-2016: > > Samsung Galaxy J5 2015 (SM-J500*) > Samsung Galaxy J5 2016 (SM-J510*) > Samsung Galaxy J3 2016 > - SM-J3109/SM-J320Y/SM-J320YZ > - SM-J320N0/SM-J320ZN > - SM-J320P/SM-J320R4/SM-J320V/SM-S320VL No need to repeat it in every commit. > > Add a common device tree for with initial support for: > > - GPIO keys > - SDHCI (internal and external storage) > - USB Device Mode > - UART (on USB connector via the SM5703 MUIC) > - WCNSS (WiFi/BT) > - Regulators > > The three devices (some varints of J3, all other variants of J5 released > in 2015 and J5X released in 2016) are very similar, with some differences > in display and GPIO pins. The common parts are shared in > msm8916-samsung-j5-common.dtsi to reduce duplication. The same. > > Signed-off-by: Lin, Meng-Bo <linmengbo0689@xxxxxxxxxxxxxx> > --- > ...6-samsung-j5.dts => msm8916-samsung-j5-common.dtsi} | 10 ++-------- Thanks for using proper format options. However your patch is not bisectable - kernel is broken here. Best regards, Krzysztof
