On 28/09/2022 08:00, Manikanta Pubbisetty wrote:
> On 9/26/2022 2:30 PM, Krzysztof Kozlowski wrote:
>> On 26/09/2022 06:57, Manikanta Pubbisetty wrote:
>>> Add DT nodes to support WoW (Wake on Wireless) feature on WCN6750
>>> WiFi hardware on SC7280 SoC.
>>>
>>> Signed-off-by: Manikanta Pubbisetty <quic_mpubbise@xxxxxxxxxxx>
>>
>> Thank you for your patch. There is something to discuss/improve.
>>
>>
>>> ---
>>> Changes from V1:
>>> - Rebased on ToT
>>>
>>> arch/arm64/boot/dts/qcom/sc7280.dtsi | 13 +++++++++++++
>>> 1 file changed, 13 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>>> index 212580316d3e..3f6a3f575339 100644
>>> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>>> @@ -752,6 +752,17 @@ wpss_smp2p_in: slave-kernel {
>>> interrupt-controller;
>>> #interrupt-cells = <2>;
>>> };
>>> +
>>> + wlan_smp2p_out: wlan-ap-to-wpss {
>>
>> Does not look like you tested the DTS against bindings. Please run `make
>> dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst
>> for instructions).
>>
>
> I'm sorry I was not aware of checking the DTS against bindings. I'll do
> the due diligence going forward. `make dtbs_check is throwing error of
> "No rule to make target". Not sure if we need pass any options to the
> command. I did try to understand the problem but all went in vain. Pls
> help understand if I'm missing anything.
There is doc explaining possible usage, but in general works perfect
without argument. If you do not have such target, means you run it on
some ancient kernel, so anyway patch cannot be accepted and has to be
rebased. Please always develop on newest kernel - newest mainline rc,
maintainer's for-next branch or linux-next.
Best regards,
Krzysztof
