On Fri, Sep 23, 2022 at 08:08:53PM +0200, Krzysztof Kozlowski wrote: > On 22/09/2022 06:01, Colin Foster wrote: > > diff --git a/Documentation/devicetree/bindings/net/dsa/mscc,ocelot.yaml b/Documentation/devicetree/bindings/net/dsa/mscc,ocelot.yaml > > index 8d93ed9c172c..bed575236261 100644 > > --- a/Documentation/devicetree/bindings/net/dsa/mscc,ocelot.yaml > > +++ b/Documentation/devicetree/bindings/net/dsa/mscc,ocelot.yaml > > @@ -54,9 +54,21 @@ description: | > > - phy-mode = "1000base-x": on ports 0, 1, 2, 3 > > - phy-mode = "2500base-x": on ports 0, 1, 2, 3 > > > > + VSC7412 (Ocelot-Ext): > > + > > + The Ocelot family consists of four devices, the VSC7511, VSC7512, VSC7513, > > + and the VSC7514. The VSC7513 and VSC7514 both have an internal MIPS > > + processor that natively support Linux. Additionally, all four devices > > + support control over external interfaces, SPI and PCIe. The Ocelot-Ext > > + driver is for the external control portion. > > + > > + The following PHY interface type are currently supported: > > + - phy-mode = "internal": on ports 0, 1, 2, 3 > > "Currently supported" by hardware or by some specific, chosen > implementation? If the latter, drop it. If the former, maybe this should > be constrained in allOf:if:then. Hi Krzysztof, Currently supported by the software. This patch set explicitly adds support for the four internal ports. There'll be another patch set right around the corner that'll add QSGMII to ports 4-7. I see your point though. I'll drop "currently" and have it match the wording of the other drivers.
