Hi Krzysztof,
On 9/22/22 14:45, Krzysztof Kozlowski wrote:
On 22/09/2022 12:12, Quentin Schulz wrote:
[...]
diff --git a/arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi b/arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi
new file mode 100644
index 000000000000..74a7f1182c21
--- /dev/null
+++ b/arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi
@@ -0,0 +1,347 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (c) 2022 Theobroma Systems Design und Consulting GmbH
+ */
+
+/dts-v1/;
+#include "px30.dtsi"
+
+/ {
+ aliases {
+ mmc0 = &emmc;
+ mmc1 = &sdio;
+ rtc0 = &rtc_twi;
+ rtc1 = &rk809;
+ };
+
+ emmc_pwrseq: emmc-pwrseq {
+ compatible = "mmc-pwrseq-emmc";
+ pinctrl-0 = <&emmc_reset>;
+ pinctrl-names = "default";
+ reset-gpios = <&gpio1 RK_PB3 GPIO_ACTIVE_HIGH>;
+ };
+
+ leds {
+ compatible = "gpio-leds";
This belongs to DTSI.
It is in the DTSI :)
+ pinctrl-names = "default";
+ pinctrl-0 = <&module_led_pin>;
+ status = "okay";
No need.
+
+ module_led: led-0 {
Why DTSI - which in logic comes first - starts with 1 and this is 0?\
The first diff in this patch is for the DTS, this is now the DTSI. So it
does have led-0 in the DTSI and led-1 in the DTS which I think is what
you're requesting here? Is this a correct assumption?
Ack for all other review comments, thanks!
Cheers,
Quentin
