Re: [PATCH 2/3] spi: Add support for the Airoha EN7523 SoC SPI controller

[kernel test robot <lkp@xxxxxxxxx>]

Hi Bert,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on broonie-spi/for-next]
[also build test WARNING on robh/for-next linus/master v6.0-rc6 next-20220921]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Bert-Vermeulen/Add-support-for-the-Airoha-EN7523-SPI-controller/20220922-183229
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
config: arm-defconfig (https://download.01.org/0day-ci/archive/20220923/202209230724.y183GHHN-lkp@xxxxxxxxx/config)
compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/1b16c3608a2ca618f1cea10164a278e931610021
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Bert-Vermeulen/Add-support-for-the-Airoha-EN7523-SPI-controller/20220922-183229
        git checkout 1b16c3608a2ca618f1cea10164a278e931610021
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/spi/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

>> drivers/spi/spi-en7523.c:219:8: warning: no previous prototype for 'max_transfer_size' [-Wmissing-prototypes]
     219 | size_t max_transfer_size(struct spi_device *spi)
         |        ^~~~~~~~~~~~~~~~~
>> drivers/spi/spi-en7523.c:224:5: warning: no previous prototype for 'transfer_one_message' [-Wmissing-prototypes]
     224 | int transfer_one_message(struct spi_controller *ctrl, struct spi_message *msg)
         |     ^~~~~~~~~~~~~~~~~~~~


vim +/max_transfer_size +219 drivers/spi/spi-en7523.c

   218	
 > 219	size_t max_transfer_size(struct spi_device *spi)
   220	{
   221		return ENSPI_MAX_XFER;
   222	}
   223	
 > 224	int transfer_one_message(struct spi_controller *ctrl, struct spi_message *msg)
   225	{
   226		struct spi_transfer *xfer;
   227		int next_xfer_is_rx = 0;
   228	
   229		manual_begin_cmd();
   230		set_cs(0);
   231		list_for_each_entry(xfer, &msg->transfers, transfer_list) {
   232			if (xfer->tx_buf) {
   233				if (!list_is_last(&xfer->transfer_list, &msg->transfers)
   234				    && list_next_entry(xfer, transfer_list)->rx_buf != NULL)
   235					next_xfer_is_rx = 1;
   236				else
   237					next_xfer_is_rx = 0;
   238				msg->actual_length += xfer_write(xfer, next_xfer_is_rx);
   239			} else if (xfer->rx_buf) {
   240				msg->actual_length += xfer_read(xfer);
   241			}
   242		}
   243		set_cs(1);
   244		manual_end_cmd();
   245	
   246		msg->status = 0;
   247		spi_finalize_current_message(ctrl);
   248	
   249		return 0;
   250	}
   251	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp