On 21/09/2022 13:45, Matti Vaittinen wrote: > KX022A is a 3-axis Accelerometer from ROHM/Kionix. The senor features > include variable ODRs, I2C and SPI control, FIFO/LIFO with watermark IRQ, Thank you for your patch. There is something to discuss/improve. > tap/motion detection, wake-up & back-to-sleep events, four acceleration > ranges (2, 4, 8 and 16g) and probably some other cool fatures. s/fatures/features/ > +$id: http://devicetree.org/schemas/iio/accel/kionix,kx022a.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: ROHM/Kionix KX022A Accelerometer bindings Drop "bindings" > + > +maintainers: > + - Matti Vaittinen <matti.vaittinen@xxxxxxxxxxxxxxxxx> > + > +description: | > + KX022A is a 3-axis accelerometer supporting +/- 2G, 4G, 8G and 16G ranges, > + output data-rates from 0.78Hz to 1600Hz and a hardware-fifo buffering. > + KX022A can be accessed either via I2C or SPI. > + > +properties: > + compatible: kionix,kx022a Missing const. I wonder how did it pass testing... > + > + reg: > + description: > + I2C slave address or SPI chip-select. Skip description, it's obvious. > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + vdd-supply: true > + io_vdd-supply: true No underscores, so io-vdd-supply > + > + mount-matrix: > + description: | > + an optional 3x3 mounting rotation matrix. > + > +required: > + - compatible > + - reg > + - interrupts > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/irq.h> > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + accel@1f { Messed up indentation. > + compatible = "kionix,kx022a"; > + reg = <0x1f>; Best regards, Krzysztof
