Hi Yinbo, I love your patch! Perhaps something to improve: [auto build test WARNING on rafael-pm/thermal] [also build test WARNING on linus/master v6.0-rc6 next-20220920] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Yinbo-Zhu/MAINTAINERS-add-maintainer-for-thermal-driver-for-loongson2-SoCs/20220921-095737 base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git thermal config: x86_64-randconfig-a011 (https://download.01.org/0day-ci/archive/20220921/202209211644.16Ox1qeg-lkp@xxxxxxxxx/config) compiler: gcc-11 (Debian 11.3.0-5) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/c21dcaa77e2e7514efdb4c97c805b14c9a05ec35 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Yinbo-Zhu/MAINTAINERS-add-maintainer-for-thermal-driver-for-loongson2-SoCs/20220921-095737 git checkout c21dcaa77e2e7514efdb4c97c805b14c9a05ec35 # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/thermal/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): >> drivers/thermal/loongson2_thermal.c:183:5: warning: no previous prototype for 'loongson2_thermal_remove' [-Wmissing-prototypes] 183 | int loongson2_thermal_remove(struct platform_device *pdev) | ^~~~~~~~~~~~~~~~~~~~~~~~ vim +/loongson2_thermal_remove +183 drivers/thermal/loongson2_thermal.c 182 > 183 int loongson2_thermal_remove(struct platform_device *pdev) 184 { 185 struct loongson2_thermal_data *data = platform_get_drvdata(pdev); 186 int reg_off = data->id * 2; 187 188 /* disable interrupt */ 189 writew(0, data->regs + LOONGSON2_TSENSOR_CTRL_LO + reg_off); 190 writew(0, data->regs + LOONGSON2_TSENSOR_CTRL_HI + reg_off); 191 192 return 0; 193 } 194 -- 0-DAY CI Kernel Test Service https://01.org/lkp
