On 19/09/2022 20:06, Viorel Suman wrote: 43 >>> #define IMX_SC_R_SECVIO 44 >>> #define IMX_SC_R_DC_1_VIDEO0 45 >>> #define IMX_SC_R_DC_1_VIDEO1 46 >>> #define IMX_SC_R_DC_1_FRAC0 47 >>> +#define IMX_SC_R_V2X 48 >>> #define IMX_SC_R_DC_1 49 >>> +#define IMX_SC_R_UNUSED14 50 >>> #define IMX_SC_R_DC_1_PLL_0 51 >>> #define IMX_SC_R_DC_1_PLL_1 52 >>> #define IMX_SC_R_SPI_0 53 >>> @@ -151,10 +154,10 @@ >>> #define IMX_SC_R_DMA_1_CH29 137 >>> #define IMX_SC_R_DMA_1_CH30 138 >>> #define IMX_SC_R_DMA_1_CH31 139 >>> -#define IMX_SC_R_UNUSED1 140 >> >> This one disappears... > > Hi Krzysztof, > > Right, it was renamed in the subsequent SCFW kit > versions to IMX_SC_R_V2X_PID0, thus - this patch > rename it in include/dt-bindings/firmware/imx/rsrc.h > file in order to have this file and SCFW kit defines > synchronized. > > IMX_SC_R_UNUSED1 is not referenced somehow in kernel, > thus - no compilation issues if renamed to IMX_SC_R_V2X_PID0, > IMHO it does not make sense to me to add the related > backward compatibility define like below: > > #define IMX_SC_R_UNUSED1 IMX_SC_R_V2X_PID0 The bindings are used by other people (other Linux kernel forks) and by other projects (like bootloaders and other operating systems). This is why once set, we do not change them, with some exceptions. Best regards, Krzysztof
