> + if (of_device_is_compatible(np, "marvell,armada-380-audio")) {
> + err = armada_38x_i2s_init_quirk(pdev, priv, soc_dai);
> + /* Set initial pll frequency */
> + if (priv->pll_config)
> + armada_38x_set_pll(priv->pll_config, 44100);
> + if (err < 0)
> + return err;
A nitpick: It would be better to do the test for err before calling
armada_38x_set_pll(), and then there is no need for the NULL check.
Andrew
