On 19.09.2022 20:08, Krzysztof Kozlowski wrote: > On Mon, 19 Sep 2022 18:08:40 +0300, Sergiu Moga wrote: >> Convert at91 USART DT Binding for Atmel/Microchip SoCs to >> json-schema format. Furthermore, move this binding to the >> serial directory, since binding directories match hardware, >> unlike the driver subsystems which match Linux convention. >> >> Signed-off-by: Sergiu Moga <sergiu.moga@xxxxxxxxxxxxx> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >> --- >> >> >> v1 -> v2: >> - only do what the commit says, split the addition of other compatibles and >> properties in other patches >> - remove unnecessary "|"'s >> - mention header in `atmel,usart-mode`'s description >> - place `if:` under `allOf:` >> - respect order of spi0's DT properties: compatible, then reg then the reset of properties >> >> v2 -> v3: >> - Previously [PATCH 5] >> - Check value of `atmel,usart-mode` instead of the node regex >> - Define all properties top level and disallow them explicitly for other type, >> since additionalProperties:false conflicts with referencing other schemas >> - Remove useless else if: after else: >> >> >> v3 -> v4: >> - add R-b tag, this was previously [PATCH 6] >> >> >> >> >> .../devicetree/bindings/mfd/atmel-usart.txt | 98 ---------- >> .../bindings/serial/atmel,at91-usart.yaml | 182 ++++++++++++++++++ >> 2 files changed, 182 insertions(+), 98 deletions(-) >> delete mode 100644 Documentation/devicetree/bindings/mfd/atmel-usart.txt >> create mode 100644 Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml >> > > Running 'make dtbs_check' with the schema in this patch gives the > following warnings. Consider if they are expected or the schema is > incorrect. These may not be new warnings. > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > This will change in the future. > > Full log is available here: https://patchwork.ozlabs.org/patch/ > > Hello, thank you for checking :). The above link issues a 404. Everything should be fine though once all of the below are merged: https://lore.kernel.org/linux-arm-kernel/53e72e5d-47fc-403d-c969-61b267a9ff15@xxxxxxxxxxxxx/ https://lore.kernel.org/linux-arm-kernel/1ae89854-74fa-6194-304f-db31d56d3674@xxxxxxxxxxxxx/ together with the patch series that I linked into the cover letter as a dependence: https://lore.kernel.org/linux-arm-kernel/20220916075744.1879428-1-kavyasree.kotagiri@xxxxxxxxxxxxx/ Thank you, Sergiu
