On Mon, Sep 19, 2022 at 08:37:23PM +0300, Laurent Pinchart wrote: > > > > + ctrl = v4l2_ctrl_new_int_menu(&tc358746->ctrl_hdl, NULL, > > > > + V4L2_CID_LINK_FREQ, 0, 0, > > > > > > Shouldn't the max argument be set to the number of items minus 1 ? > > > > Right now I would keep it that way since the driver only supports one > > link-frequencies setting. So the ctrl don't let the userspace assume > > that there are more than one link-frequency. > > Good point. Can you add a short comment above the call to explain this ? Wouldn't it be just easier to do what Laurent suggested originally? The end result is the same, isn't it, and no comment needed? > > > > > + link_frequencies); > > > > + if (ctrl) > > > > + ctrl->flags |= V4L2_CTRL_FLAG_READ_ONLY; Now that this is a bridge, this value presumably doesn't need to change. There will just be more blanking if the source sub-device pixel rate is slower, right? -- Sakari Ailus
