On 22-09-19 13:40:18, Krzysztof Kozlowski wrote: > On 19/09/2022 13:37, Viorel Suman (OSS) wrote: > > From: Viorel Suman <viorel.suman@xxxxxxx> > > > > Sync defines with the latest available SCFW kit version 1.13.0, > > may be found at the URL below: > > > > https://www.nxp.com/webapp/Download?colCode=L5.15.32_2.0.0_SCFWKIT-1.13.0&appType=license > > > > Signed-off-by: Viorel Suman <viorel.suman@xxxxxxx> > > --- > > drivers/clk/imx/clk-imx8qm-rsrc.c | 4 +- > > include/dt-bindings/firmware/imx/rsrc.h | 292 ++++++++++++++++-------- > > Bindings cannot be squashed with driver change. > > > 2 files changed, 198 insertions(+), 98 deletions(-) > > > > Changes since v1: > > Two patches squashed into one in order to keep changes bissectable > > and compilable as suggested by Alexander Stein. > > That's not the solution. Solution is to make driver behaving correctly, > not squash patches which must not be together. > > This is proof of an ABI break, so NAK unless described why it is OK to > break the ABI/users/boards. Hi Krzysztof, In v3 I've added two more defines in backward compatibility section in order to avoid breaking ABI, so there is no need to change the driver anymore. Regards, Viorel
