On 19/09/2022 13:49, Sergio Paracuellos wrote: > Hi Krzysztof, > > Thanks for the review. > > On Mon, Sep 19, 2022 at 1:20 PM Krzysztof Kozlowski > <krzysztof.kozlowski@xxxxxxxxxx> wrote: >> >> On 17/09/2022 06:27, Sergio Paracuellos wrote: >>> SoC MT7621 I2C bindings used text format, so migrate them to YAML. >>> >>> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@xxxxxxxxx> >>> --- >> >> Again, do not base your patches on something old. > > I will take it into account from now on. Since it was just an addition > and removal of a file I thought it was not important. So, I guess some > address I am using in CC is not listed in the MAINTAINERS file now?? You keep cc-ing my address which was changed in mainline around half a year ago. Patches end up in different mailbox. (...) >> >>> + >>> + clocks: >>> + maxItems: 1 >>> + >>> + clock-names: >>> + const: i2c >> >> Why adding this? >> >> You need to describe in commit msg all deviations from pure conversion. > > Looking into the users of this binding I added all the stuff I found > in dts nodes. So I think it is preferred to just make a pure > conversion and set unevaluatedProperties to true? No, unevaluatedProperties must stay false. As I said: "You need to describe in commit msg all deviations from pure conversion." I did not say preferred is to make pure conversion... Best regards, Krzysztof
