On 16/09/2022 06:00, Sergio Paracuellos wrote: > SoC MT7621 SPI bindings used text format, so migrate them to YAML. > Rebase your patch on recent Linux kernel. > Signed-off-by: Sergio Paracuellos <sergio.paracuellos@xxxxxxxxx> > --- > .../bindings/spi/ralink,mt7621-spi.yaml | 68 +++++++++++++++++++ > .../devicetree/bindings/spi/spi-mt7621.txt | 26 ------- > 2 files changed, 68 insertions(+), 26 deletions(-) > create mode 100644 Documentation/devicetree/bindings/spi/ralink,mt7621-spi.yaml > delete mode 100644 Documentation/devicetree/bindings/spi/spi-mt7621.txt > > diff --git a/Documentation/devicetree/bindings/spi/ralink,mt7621-spi.yaml b/Documentation/devicetree/bindings/spi/ralink,mt7621-spi.yaml > new file mode 100644 > index 000000000000..a602406e2669 > --- /dev/null > +++ b/Documentation/devicetree/bindings/spi/ralink,mt7621-spi.yaml > @@ -0,0 +1,68 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/spi/ralink,mt7621-spi.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +maintainers: > + - Sergio Paracuellos <sergio.paracuellos@xxxxxxxxx> > + > +title: Mediatek MT7621/MT7628 SPI controller > + > +allOf: > + - $ref: /schemas/spi/spi-controller.yaml# > + > +properties: > + compatible: > + const: ralink,mt7621-spi > + > + reg: > + maxItems: 1 > + > + '#address-cells': > + const: 1 > + > + '#size-cells': > + const: 0 Aren't these coming from spi-controller? > + > + clocks: > + maxItems: 1 You need to describe changes done. This does not look like pure conversion. > + > + clock-names: > + const: spi Why? > + > + resets: > + maxItems: 1 > + > + reset-names: > + const: spi Why? > + > +required: > + - compatible > + - reg > + - resets > + - reset-names Why? > + - "#address-cells" > + - "#size-cells" Use same style of quotes. > + > +unevaluatedProperties: false > + Best regards, Krzysztof
