On 19/09/2022 10:04, Jianguo Zhang wrote: > Add binding document for the ethernet on mt8188 > > Signed-off-by: Jianguo Zhang <jianguo.zhang@xxxxxxxxxxxx> > --- > Documentation/devicetree/bindings/net/mediatek-dwmac.yaml | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml b/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml > index 61b2fb9e141b..b7d4f956f92e 100644 > --- a/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/mediatek-dwmac.yaml > @@ -20,6 +20,7 @@ select: > enum: > - mediatek,mt2712-gmac > - mediatek,mt8195-gmac > + - mediatek,mt8188-gmac Won't be needed after comment below. > required: > - compatible > > @@ -36,6 +37,7 @@ properties: > - items: > - enum: > - mediatek,mt8195-gmac > + - mediatek,mt8188-gmac That's not what your driver change is saying. They are the same or compatible according to your patch #1. > - const: snps,dwmac-5.10a Best regards, Krzysztof