Re: [RFC PATCH 1/7] arm64: qcom: dts: c630: correct firmware paths

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Dmitry,

On 9/15/22 10:26 AM, Dmitry Baryshkov wrote:
Correct firmware paths for the Lenovo Yoga C630 to include the SoC name.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
---
  arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
index be59a8ba9c1f..35d367bf97a4 100644
--- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
+++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
@@ -94,7 +94,7 @@ backlight: backlight {
  };
&adsp_pas {
-	firmware-name = "qcom/LENOVO/81JL/qcadsp850.mbn";
+	firmware-name = "qcom/sdm850/LENOVO/81JL/qcadsp850.mbn";
  	status = "okay";
  };
@@ -306,7 +306,7 @@ vreg_lvs2a_1p8: lvs2 {
  };
&cdsp_pas {
-	firmware-name = "qcom/LENOVO/81JL/qccdsp850.mbn";
+	firmware-name = "qcom/sdm850/LENOVO/81JL/qccdsp850.mbn";
  	status = "okay";
  };
@@ -345,7 +345,7 @@ &gpu {
  	status = "okay";
  	zap-shader {
  		memory-region = <&gpu_mem>;
-		firmware-name = "qcom/LENOVO/81JL/qcdxkmsuc850.mbn";
+		firmware-name = "qcom/sdm850/LENOVO/81JL/qcdxkmsuc850.mbn";
  	};
  };
@@ -475,7 +475,7 @@ &mdss { &mss_pil {
  	status = "okay";
-	firmware-name = "qcom/LENOVO/81JL/qcdsp1v2850.mbn", "qcom/LENOVO/81JL/qcdsp2850.mbn";
+	firmware-name = "qcom/sdm850/LENOVO/81JL/qcdsp1v2850.mbn", "qcom/sdm850/LENOVO/81JL/qcdsp2850.mbn";
  };
&qup_i2c10_default {

Since this firmware comes from the Windows partitions for these machines, and I know there are a few installations out in the wild, this might break things for others - unlike the Thinkpad X13s which works "fine" (the battery won't charge if the adsp firmware isn't in place), iirc, the c630 doesn't boot properly without it?

That said, I've moved the firmware to the location above manually, and it does work so

Tested-by: Steev Klimaszewski <steev@xxxxxxxx>





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux